viirya commented on a change in pull request #29475:
URL: https://github.com/apache/spark/pull/29475#discussion_r474328452
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -131,14 +131,15 @@ case class InSubqueryExec(
def updateResult(): Unit = {
val rows = plan.executeCollect()
- result = child.dataType match {
- case _: StructType => rows.toArray
- case _ => rows.map(_.get(0, child.dataType))
- }
+ // The child is always partition column. So it must be AtomicType.
Review comment:
I don't get it. What it meant "PlanSubqueries actually has one
element."? `PlanSubqueries` has the code to pass a struct into
`InSubqueryExec`, isn't? Otherwise it is useless and we should remove it too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
