viirya commented on a change in pull request #29475:
URL: https://github.com/apache/spark/pull/29475#discussion_r474390728
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -131,14 +131,15 @@ case class InSubqueryExec(
def updateResult(): Unit = {
val rows = plan.executeCollect()
- result = child.dataType match {
- case _: StructType => rows.toArray
- case _ => rows.map(_.get(0, child.dataType))
- }
+ // The child is always partition column. So it must be AtomicType.
Review comment:
Yeah, I meant
https://github.com/apache/spark/blob/68034a805607ced50dbedca73dfc7eaf0102dde8/sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala#L186-L196,
especially L189-L193 that creates `CreateNamedStruct`.
If "The child is always partition column" is true, then it means we don't
need the code at `subquery.scala` that passes a struct into `InSubqueryExec`.
Isn't?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
