anchovYu commented on a change in pull request #29497: URL: https://github.com/apache/spark/pull/29497#discussion_r474850404
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/CatalystErrors.scala ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import org.apache.spark.sql.catalyst.expressions.{Expression, GroupingID} +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan +import org.apache.spark.sql.catalyst.util.toPrettySQL +import org.apache.spark.sql.connector.catalog.TableChange +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.sql.types.{AbstractDataType, DataType, StructType} + +/** + * Object for grouping all error messages in catalyst. + * Currently it includes all AnalysisExcpetions created and thrown directly in + * org.apache.spark.sql.catalyst.analysis.Analyzer. + */ +object CatalystErrors { + def groupingIDMismatchError(groupingID: GroupingID, groupByExprs: Seq[Expression]): Throwable = { Review comment: This is a summary sheet of raw exceptions thrown in Catalyst of branch-3.0: [OSS Catalyst Exception Messages: Branch-3.0](https://docs.google.com/spreadsheets/d/10HmOs-RIRaur2b_zLuOpRXC2b45KfpHwTBpQyalTV-s/edit?usp=sharing). Apart from `AnalysisException` and its sub-exceptions, there are a lot of other exceptions, for example, `IllegalArgumentException` and `UnsupportedOperationException`. We generally have two ways to group these messages: * By component. All messages from a single components, no matter the exception type, are grouped into one exception file. * By exception type. All messages of a single exception type are created in the corresponding exception object. It is great because by calling `AnalysisException.groupingIDMismatchError` we know the exception type this function throws. But this approach has a problem: those Java/Scala internal exception type cannot follow this way. Due to the small problem of the latter one, I choose the first one of grouping all exception messages from Catalyst in one file. Or do you have any thoughts on that? Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
