maropu commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-679868589
> one idea is to use different package names for different modules: Ah, I see. Splitting exceptions into multiple fine-graind groups looks a nice idea. > How to organize them? query compilation/query execution + package seems okay, but is there possibly unclear cases? For example, AnalysisException is also thrown in RunnableCommand, is it query compilation error and query execution error? I agree to the @viirya suggestion and I think we need a simple but clear rule to categorize exceptions into groups so that developers do not get confused. Probably, we can follow a simple mapping based on exception classes? e.g., ``` AnalyssiException => QueryCompilationErrors SparkException, RuntimeException(UnsupportedOperationException, IllegalStateException, ...) => QueryExecutionErrors ... ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
