chanduhawk commented on a change in pull request #29516:
URL: https://github.com/apache/spark/pull/29516#discussion_r475171964
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala
##########
@@ -220,7 +220,9 @@ class CSVOptions(
format.setQuote(quote)
format.setQuoteEscape(escape)
charToEscapeQuoteEscaping.foreach(format.setCharToEscapeQuoteEscaping)
- format.setComment(comment)
+ if (isCommentSet) {
Review comment:
If we will change that way then it might impact existing users for which
\u0000 is a comment character by default. So I would say a separate optional
config is a better solution. What I am saying here is that we need to wait for
univocity 3.0.0 to be available where the new changes will be available then we
can add spark changes in a proper manner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
