srowen commented on a change in pull request #29516:
URL: https://github.com/apache/spark/pull/29516#discussion_r475241297
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala
##########
@@ -220,7 +220,9 @@ class CSVOptions(
format.setQuote(quote)
format.setQuoteEscape(escape)
charToEscapeQuoteEscaping.foreach(format.setCharToEscapeQuoteEscaping)
- format.setComment(comment)
+ if (isCommentSet) {
Review comment:
I agree, I'll fix that in the next commit - we need to set the comment
char to whatever Spark is using no matter what. However it looks like we are
going to need your univocity fix to really fix this. Looks like that was just
released in 2.9.0:
https://github.com/uniVocity/univocity-parsers/commit/f392311ad01676bcd0adf007c2f553112d8eb7c3
let me try that.
@dongjoon-hyun it is a correctness issue but I wouldn't hold up a release
for it. We should address it but doesn't absolutely have to happen in 2.4.7 or
3.0.1. It's not a regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
