dongjoon-hyun commented on a change in pull request #29387:
URL: https://github.com/apache/spark/pull/29387#discussion_r475900361



##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -269,6 +269,26 @@ private[spark] object Utils extends Logging {
     file.setExecutable(true, true)
   }
 
+  /**
+   * Move data to trash on truncate table given

Review comment:
       Let's remove `on truncate table` here because this is `core` module.
   This can be used in another place in the future (e.g. your INSERT INTO 
OVERWRITE PR).
   ```
   Move data to trash if 'spark.sql.truncate.trash.enabled' is true
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to