dongjoon-hyun commented on a change in pull request #29387:
URL: https://github.com/apache/spark/pull/29387#discussion_r475901104
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -269,6 +269,26 @@ private[spark] object Utils extends Logging {
file.setExecutable(true, true)
}
+ /**
+ * Move data to trash on truncate table given
+ * 'spark.sql.truncate.trash.enabled' is true
+ */
+ def moveToTrashIfEnabled(
+ fs: FileSystem,
+ partitionPath: Path,
+ isTrashEnabled: Boolean,
+ hadoopConf: Configuration): Unit = {
+ if (isTrashEnabled) {
+ logDebug(s"will move data ${partitionPath.toString} to trash")
+ val isSuccess = Trash.moveToAppropriateTrash(fs, partitionPath,
hadoopConf)
+ if (!isSuccess) {
+ logWarning(s"Failed to move data ${partitionPath.toString} to trash")
Review comment:
Warning is okay, but we need to do fallback to the original behavior.
```scala
fs.delete(partitionPath, true)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
