HyukjinKwon commented on a change in pull request #29537:
URL: https://github.com/apache/spark/pull/29537#discussion_r476177245
##########
File path:
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q11.sf100/explain.txt
##########
@@ -89,394 +89,394 @@ TakeOrderedAndProject (87)
(1) Scan parquet default.store_sales
-Output [4]: [ss_sold_date_sk#1, ss_customer_sk#2, ss_ext_discount_amt#3,
ss_ext_list_price#4]
+Output [4]: [ss_sold_date_sk#x, ss_customer_sk#x, ss_ext_discount_amt#x,
ss_ext_list_price#x]
Batched: true
-Location: InMemoryFileIndex
[file:/Users/yi.wu/IdeaProjects/spark/sql/core/spark-warehouse/org.apache.spark.sql.TPCDSV1_4_PlanStabilityWithStatsSuite/store_sales]
Review comment:
Hm, how do we check the differences by other changes but not caught by
this test?
I think we should only result simplified forms here if we test simplified
forms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
