Ngone51 commented on a change in pull request #29537:
URL: https://github.com/apache/spark/pull/29537#discussion_r476213911



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##########
@@ -102,8 +104,8 @@ trait PlanStabilitySuite extends TPCDSBase with 
DisableAdaptiveExecutionSuite {
 
   private def isApproved(dir: File, actualSimplifiedPlan: String): Boolean = {
     val file = new File(dir, "simplified.txt")
-    val approved = FileUtils.readFileToString(file, StandardCharsets.UTF_8)
-    approved == actualSimplifiedPlan
+    val expected = FileUtils.readFileToString(file, StandardCharsets.UTF_8)
+    expected == actualSimplifiedPlan

Review comment:
       Address the comment from 
https://github.com/apache/spark/pull/29270#discussion_r476178381




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to