viirya commented on a change in pull request #29560:
URL: https://github.com/apache/spark/pull/29560#discussion_r478692673
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala
##########
@@ -65,3 +67,8 @@ class TPCDSQuerySuite extends BenchmarkQueryTest with
TPCDSBase {
class TPCDSQueryWithStatsSuite extends TPCDSQuerySuite {
override def injectStats: Boolean = true
}
+
+class TPCDSQueryANSISuite extends TPCDSQuerySuite {
+ override protected def sparkConf: SparkConf =
+ super.sparkConf.set(SQLConf.ANSI_ENABLED, true)
+}
Review comment:
It sounds not a problem of ANSI mode or these queries. I think these
queries just conflict with ANSI mode. To unblock TPCDS under ANSI mode, the
change is okay.
The concern I have is that if we will remove more keywords from ANSI mode
like this, then is ANSI mode still be necessary? This might be a rare case and
the concern maybe not valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
