cloud-fan commented on a change in pull request #29560:
URL: https://github.com/apache/spark/pull/29560#discussion_r478826919
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala
##########
@@ -65,3 +67,8 @@ class TPCDSQuerySuite extends BenchmarkQueryTest with
TPCDSBase {
class TPCDSQueryWithStatsSuite extends TPCDSQuerySuite {
override def injectStats: Boolean = true
}
+
+class TPCDSQueryANSISuite extends TPCDSQuerySuite {
+ override protected def sparkConf: SparkConf =
+ super.sparkConf.set(SQLConf.ANSI_ENABLED, true)
+}
Review comment:
I interpret ANSI mode as a better SQL dialect of Spark, which is ANSI
compliant but not 100% the same as the ANSI standard. No database is 100% the
same as ANSI, there are always extensions, e.g. unreserve some reserved
keywords for better usability.
If a vector builds a product with spark on ANSI mode, and can't run TPCDS
queries, I think the ANSI mode is problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
