viirya commented on a change in pull request #29544:
URL: https://github.com/apache/spark/pull/29544#discussion_r478776434
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
##########
@@ -153,11 +220,12 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]]
extends Logging {
if (effective) {
queryExecutionMetrics.incNumEffectiveExecution(rule.ruleName)
queryExecutionMetrics.incTimeEffectiveExecutionBy(rule.ruleName,
runTime)
- planChangeLogger.logRule(rule.ruleName, plan, result)
}
queryExecutionMetrics.incExecutionTimeBy(rule.ruleName, runTime)
queryExecutionMetrics.incNumExecution(rule.ruleName)
+ planChangeLogger.logRule(rule.ruleName, plan, result)
+
Review comment:
Move out of `if (effective) { ... }` by intention? Won't it be flooded
with too many log?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
