cloud-fan commented on a change in pull request #29544:
URL: https://github.com/apache/spark/pull/29544#discussion_r478824595
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
##########
@@ -44,6 +44,73 @@ object RuleExecutor {
}
}
+class PlanChangeLogger[TreeType <: TreeNode[_]] extends Logging {
+
+ private val logLevel = SQLConf.get.planChangeLogLevel
+
+ private val logRules = SQLConf.get.planChangeRules.map(Utils.stringToSeq)
+
+ private val logBatches = SQLConf.get.planChangeBatches.map(Utils.stringToSeq)
+
+ def logRule(ruleName: String, oldPlan: TreeType, newPlan: TreeType): Unit = {
+ if (!newPlan.fastEquals(oldPlan)) {
+ if (logRules.isEmpty || logRules.get.contains(ruleName)) {
+ def message(): String = {
+ s"""
+ |=== Applying Rule $ruleName ===
+ |${sideBySide(oldPlan.treeString,
newPlan.treeString).mkString("\n")}
+ """.stripMargin
+ }
Review comment:
shall we follow
https://github.com/apache/spark/pull/29544/files#diff-f70523b948b7af21abddfa3ab7e1d7d6R79
and log something like `Rule xxx has no effect`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
