sunchao commented on pull request #29567: URL: https://github.com/apache/spark/pull/29567#issuecomment-682395070
Thanks for checking. I made a few mistakes in the PR. Firstly, the second rule should be: ``` if(p, null, true) => or(not(p), null) ``` Secondly, the predicate `p` should be deterministic and evaluate to either true or false, but not null. I'll see how we can put restriction that. Since three-valued logic has the following properties: | a | b | a and b | a or b | | --| --| ----| ----| | true | null | null | true | | false | null | false | null | I think the above should be semantically equivalent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
