tanelk commented on pull request #29567: URL: https://github.com/apache/spark/pull/29567#issuecomment-682461280
I think it should be correct now, but it would be nice to have some checks in the tests. Are there equivalent cases for `if(p, false, null)` and `if(p, true, null)`? Perhaps instead of a new `Rule` the cases could be added to the existing `SimplifyConditionals`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
