Github user tsudukim commented on the pull request:

    https://github.com/apache/spark/pull/5227#issuecomment-88761331
  
    Ah @vanzin, I didn't understand your suggestion. `CommandBuilderUtils` 
needs modified to escape comma.
    But I think we still need to modify `spark-class2.cmd` as well.
    
    When we execute `bin\spark-shell.cmd --jars "C:\Path to\jar1.jar,C:\Path 
to\jar2.jar"`, 
    we get following with original `spark-class2.cmd` even if 
`CommandBuilderUtils` is fixed to escape comma.
    `... --jars "C:\Path to\jar1.jar C:\Path to\jar2.jar" ...`
    but we get with my PR `spark-class2.cmd`
    `... --jars "C:\Path to\jar1.jar,C:\Path to\jar2.jar" ...`
    
    Two job at the same time is surely a problem, so added random string to the 
filename to reduce the probability this problem occurs.
    
    I know it's better to solve this problem without using temporary file if 
possible, but I have no idea now. If you've got any suggestion, please let me 
know.
    I'd really like to replace all *.cmd to powershell rather than write ugly 
codes like this....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to