dongjoon-hyun commented on a change in pull request #28911:
URL: https://github.com/apache/spark/pull/28911#discussion_r479695389
##########
File path:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
##########
@@ -113,6 +113,15 @@ class NettyBlockRpcServer(
s"when there is not sufficient space available to store the
block.")
responseContext.onFailure(exception)
}
+
+ case getLocalDirs: GetLocalDirsForExecutors =>
+ assert(getLocalDirs.appId == appId)
+ assert(getLocalDirs.execIds.length == 1)
Review comment:
Although we have these assertions, what happen when this
`NettyBlockRpcServer` receives a wrong message, `GetLocalDirsForExecutors` with
an irrelevant `execId`? It seems that we trust the sender always and reply with
the received `execId`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
