dongjoon-hyun commented on a change in pull request #28911:
URL: https://github.com/apache/spark/pull/28911#discussion_r479698150
##########
File path:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
##########
@@ -66,16 +66,24 @@ class ShuffleBlockFetcherIteratorSuite extends
SparkFunSuite with PrivateMethodT
transfer
}
+ private def createMockBlockManager(): BlockManager = {
+ val blockManager = mock(classOf[BlockManager])
+ val localBmId = BlockManagerId("test-client", "test-local-host", 1)
+ doReturn(localBmId).when(blockManager).blockManagerId
+ // By default, the mock BlockManager returns None for hostLocalDirManager.
One could
+ // still use initHostLocalDirManager() to specify a custom
hostLocalDirManager.
Review comment:
Just a question. Is there an instance which is not using this default?
##########
File path:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
##########
@@ -66,16 +66,24 @@ class ShuffleBlockFetcherIteratorSuite extends
SparkFunSuite with PrivateMethodT
transfer
}
+ private def createMockBlockManager(): BlockManager = {
+ val blockManager = mock(classOf[BlockManager])
+ val localBmId = BlockManagerId("test-client", "test-local-host", 1)
+ doReturn(localBmId).when(blockManager).blockManagerId
+ // By default, the mock BlockManager returns None for hostLocalDirManager.
One could
+ // still use initHostLocalDirManager() to specify a custom
hostLocalDirManager.
Review comment:
Just a question. Currently, is there an instance which is not using this
default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
