Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5327#discussion_r27638972
  
    --- Diff: sbin/spark-daemon.sh ---
    @@ -195,6 +195,23 @@ case $option in
         fi
         ;;
     
    +  (status)
    +
    +    if [ -f $pid ]; then
    +      TARGET_PID=`cat $pid`
    +      if kill -0 $TARGET_PID > /dev/null 2>&1; then
    --- End diff --
    
    See how the process is detected in the rest of this file. The problem with 
this is that theoretically you would report the process is running even if, 
somehow, it had died and the PID was still around but another process had taken 
on the same ID. It's possible to be more defensive. Heck, if you know enough 
`bash`, make a local function for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to