dbtsai commented on pull request #29567: URL: https://github.com/apache/spark/pull/29567#issuecomment-683525201
> cc @gatorsmile since he expressed his concerns at that time. I think the concern @gatorsmile had was in https://github.com/apache/spark/pull/21850, converting `CaseWhen` to `If`, we will not get too much performance gain. However, this PR is trying to convert `If` to `And` or `Or` when possible, so we are able to pushdown more into data source. With this merged, we could revisit https://github.com/apache/spark/pull/21850 since it opens up the possibility that when we have one branch in `CaseWhen`, we can potentially optimize it to `And` or `Or`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
