AngersZhuuuu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r480210028
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1428,8 +1428,36 @@ class Analyzer(
// SPARK-25942: Resolves aggregate expressions with `AppendColumns`'s
children, instead of
// `AppendColumns`, because `AppendColumns`'s serializer might produce
conflict attribute
// names leading to ambiguous references exception.
- case a @ Aggregate(groupingExprs, aggExprs, appendColumns:
AppendColumns) =>
- a.mapExpressions(resolveExpressionTopDown(_, appendColumns))
+ case a: Aggregate =>
+ val planForResolve = a.child match {
Review comment:
> nit: move the original comment `//
[SPARK-25942](https://issues.apache.org/jira/browse/SPARK-25942): ....` above
this line.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
