AngersZhuuuu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r480838692
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1326,7 +1326,11 @@ class Analyzer(
* Note : In this routine, the unresolved attributes are resolved from the
input plan's
* children attributes.
*/
- private def resolveExpressionTopDown(e: Expression, q: LogicalPlan):
Expression = {
+ private def resolveExpressionTopDown(
+ e: Expression,
+ q: LogicalPlan,
+ trimAlias: Boolean = false,
+ isTopLevel: Boolean = false): Expression = {
Review comment:
> `isTopLevel` should be true by default, otherwise the semantic is
wrong when callers call `resolveExpressionTopDown` without specifying
`isTopLevel`.
Got your point, make this param controlled by this method make this method
more safety.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
