HyukjinKwon commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r480566498
##########
File path: python/pyspark/cloudpickle.pyi
##########
@@ -0,0 +1,86 @@
+#
Review comment:
I remember mypy just ignores and doesn't require `type: ignore` when the
type hints don't exist. That's what I experienced in another project that uses
type hints but maybe I am missing some cases here.
In any event, let's port first in whichever way best to you, and then we can
try to remove non-API type hints separately as a followup. Please go ahead in
whichever way easiest to you as the initial port!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
