LuciferYang commented on a change in pull request #29608:
URL: https://github.com/apache/spark/pull/29608#discussion_r481582101
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##########
@@ -152,7 +152,7 @@ class ExpressionsSchemaSuite extends QueryTest with
SharedSparkSession {
val outputSize = outputs.size
val headerSize = header.size
- val expectedOutputs: Seq[QueryOutput] = {
+ val (expectedMissExamples, expectedOutputs): (Array[String],
Seq[QueryOutput]) = {
Review comment:
First changed to `val (expectedMissingExamples: Array[String],
expectedOutputs: Seq[QueryOutput])`, but I feel the type declaration here is
redundant, so changed to `val (expectedMissingExamples, expectedOutputs)`. Is
this acceptable？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
