zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r484200753
##########
File path: dev/tox.ini
##########
@@ -20,5 +20,16 @@
exclude=python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,wor
[flake8]
select = E901,E999,F821,F822,F823,F401,F405
-exclude =
python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*
+exclude =
python/pyspark/cloudpickle/*.py,shared.py*,python/docs/source/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*,python/out
max-line-length = 100
+per-file-ignores =
+ python/pyspark/sql/tests/test_arrow.py: F405
+ python/pyspark/sql/tests/test_dataframe.py: F405
+ python/pyspark/sql/tests/test_pandas_udf_scalar.py: F405
+ python/pyspark/sql/tests/test_udf.py: F405
+ python/pyspark/testing/streamingutils.py: F821
+ python/pyspark/testing/mlutils.py: F821
Review comment:
Sounds reasonable, though I'd prefer to use mixed strategy:
- Less specific `type: ignore` for non-pyi files.
- Ignore selected `pyi` files in flake8.
This way we can get the most coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
