zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r484200653
##########
File path: examples/src/main/python/ml/estimator_transformer_param_example.py
##########
@@ -54,7 +56,7 @@
print(model1.extractParamMap())
# We may alternatively specify parameters using a Python dictionary as a
paramMap
- paramMap = {lr.maxIter: 20}
+ paramMap: Dict[Param, Any] = {lr.maxIter: 20}
Review comment:
I guess we could just `type: ignore` such cases - it would get most (or
at least some) of the benefits, while by unobtrusive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]