Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/4807#issuecomment-89117599
@jkbradley Thanks for the proposal and it looks reasonable.
Just two minor things not clear,
1. Should different algorithms have different entrance in LDA, like
runGibbs, runOnline, runEM? I kinda like it.
2. Online LDA have several specific arguments. What's the recommended place
to put them and their getter/setter, in LDA or optimizer ?
I'm good with other parts. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
