Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/4807#issuecomment-89189465
Just double checking, your suggestion would be to rebase from master,
implement those general changes, then commit/push the modified branch?
Primary reason I did it this way was to refactor/abstract along the method
boundaries that exist right now, but as you noted it does mix model/algorithm.
I like your approach on extending the abstract class with trait. I haven't
taken much time to work on it, but could do that over the next couple days. I
also plan on being at Databricks on Wednesday for the training if you want to
chat then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
