LuciferYang commented on a change in pull request #29660:
URL: https://github.com/apache/spark/pull/29660#discussion_r484332008
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
##########
@@ -38,7 +40,9 @@ class GenericArrayData(val array: Array[Any]) extends
ArrayData {
def this(primitiveArray: Array[Boolean]) = this(primitiveArray.toSeq)
def this(seqOrArray: Any) = this(seqOrArray match {
- case seq: Seq[Any] => seq.toArray
+ // Specified this as`scala.collection.Seq` because seqOrArray can be
+ // `mutable.ArraySeq` in Scala 2.13
+ case seq: scala.collection.Seq[Any] => seq.toArray
Review comment:
The entrance is
https://github.com/apache/spark/blob/04f7f6dac0b9177e11482cca4e7ebf7b7564e45f/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala#L28-L38
not easy to call `toSeq`, so I changed it here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
