srowen commented on a change in pull request #29660:
URL: https://github.com/apache/spark/pull/29660#discussion_r484491139
##########
File path: sql/core/src/test/resources/sql-functions/sql-expression-schema.md
##########
@@ -2,7 +2,7 @@
## Summary
- Number of queries: 339
- Number of expressions that missing example: 34
- - Expressions missing examples:
and,string,tinyint,double,smallint,date,decimal,boolean,float,binary,bigint,int,timestamp,struct,cume_dist,dense_rank,input_file_block_length,input_file_block_start,input_file_name,lag,lead,monotonically_increasing_id,ntile,!,not,or,percent_rank,rank,row_number,spark_partition_id,version,window,positive,count_min_sketch
+ - Expressions missing examples:
and,bigint,binary,boolean,date,decimal,double,float,int,smallint,string,timestamp,tinyint,struct,cume_dist,dense_rank,input_file_block_length,input_file_block_start,input_file_name,lag,lead,monotonically_increasing_id,ntile,!,not,or,percent_rank,rank,row_number,spark_partition_id,version,window,positive,count_min_sketch
Review comment:
Is this change part of the PR on purpose?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -478,15 +478,15 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
if (decimalVal.eq(null) && that.decimalVal.eq(null) && scale ==
that.scale) {
Decimal(longVal + that.longVal, Math.max(precision, that.precision),
scale)
} else {
- Decimal(toBigDecimal + that.toBigDecimal)
Review comment:
I don't think we want to set a MathContext here anyway?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
