srowen commented on a change in pull request #29660:
URL: https://github.com/apache/spark/pull/29660#discussion_r484509296
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -478,15 +478,15 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
if (decimalVal.eq(null) && that.decimalVal.eq(null) && scale ==
that.scale) {
Decimal(longVal + that.longVal, Math.max(precision, that.precision),
scale)
} else {
- Decimal(toBigDecimal + that.toBigDecimal)
Review comment:
I think the change is OK here, because we actually do not want to modify
the rounding, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
