Ngone51 commented on a change in pull request #29722:
URL: https://github.com/apache/spark/pull/29722#discussion_r487633782
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -166,17 +166,6 @@ private[spark] class CoarseGrainedExecutorBackend(
if (executor == null) {
exitExecutor(1, "Received LaunchTask command but executor was null")
} else {
- if (decommissioned) {
Review comment:
It does happen but it's meaningless to send a decommission notification
to driver at this point. Because we assume that we've already sent the
notification when `decommissioned=true`(if decommission is triggered at
executor).
It happens when `CoarseGrainedSchedulerBackend` handles `ReviveOffers`
before `ExecutorDecommissioned`. (executor decommission can happen at any time
so we can not guarantee the orders between `ReviveOffers` and
`ExecutorDecommissioned`.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
