Ngone51 commented on a change in pull request #29722:
URL: https://github.com/apache/spark/pull/29722#discussion_r487657421
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala
##########
@@ -95,8 +95,13 @@ private[spark] object CoarseGrainedClusterMessages {
case class RemoveExecutor(executorId: String, reason: ExecutorLossReason)
extends CoarseGrainedClusterMessage
- case class DecommissionExecutor(executorId: String, decommissionInfo:
ExecutorDecommissionInfo)
- extends CoarseGrainedClusterMessage
+ // A message that sent from executor to driver to tell driver that the
executor has been
+ // used. It's used for the case where decommission is triggered at executor
(e.g., K8S)
+ case class ExecutorDecommissioned(executorId: String)
+
+ // A message that sent from driver to executor to decommission that executor.
+ // It's used for Standalone's case yet, where decommission is triggered at
Worker.
Review comment:
Ok, I actually mean it used for both two cases as they would trigger
decommission at Worker side anyway. I'll update the comment to make it clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
