cloud-fan commented on a change in pull request #29722:
URL: https://github.com/apache/spark/pull/29722#discussion_r487855223
##########
File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
##########
@@ -768,11 +768,14 @@ private[deploy] class Worker(
}
}
- private[deploy] def decommissionSelf(): Boolean = {
+ private[deploy] def decommissionSelf(triggeredByWorker: Boolean): Boolean = {
Review comment:
similarly, there is only one caller side using `triggeredByWorker=true`,
we can keep this method unchanged and put the extra code to that caller side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]