cloud-fan commented on a change in pull request #29722:
URL: https://github.com/apache/spark/pull/29722#discussion_r487856488
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -264,17 +253,21 @@ private[spark] class CoarseGrainedExecutorBackend(
System.exit(code)
}
- private def decommissionSelf(): Boolean = {
+ private def decommissionSelf(triggeredByExecutor: Boolean): Boolean = {
val msg = "Decommissioning self w/sync"
logInfo(msg)
try {
decommissioned = true
- // Tell master we are are decommissioned so it stops trying to schedule
us
- if (driver.nonEmpty) {
- driver.get.askSync[Boolean](DecommissionExecutor(
- executorId, ExecutorDecommissionInfo(msg)))
- } else {
- logError("No driver to message decommissioning.")
+ if (env.conf.get(STORAGE_DECOMMISSION_ENABLED)) {
+ env.blockManager.decommissionBlockManager()
+ }
+ // Tell driver we starts decommissioning so it stops trying to schedule
us
+ if (triggeredByExecutor) {
Review comment:
similar, we can move this extra code to the caller side, and this method
doesn't need the `triggeredByExecutor` parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
