Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/5244#issuecomment-89439386
This is a well thought-out change. I prefer the explicit `--private-ips`
option to the implicit address searching of #4038, but I must ask:
@mdagost Did you try the patch in #4038? Did it not meet your needs?
Also, while this change looks good, it touches a lot of code.
Unfortunately, we don't have any automated test suites for spark-ec2 at this
time.
In lieu of that, could you use
[`coverage`](https://pypi.python.org/pypi/coverage/3.7.1) and post a report
showing that you've tested most of the critical code paths?
Sorry to put this extra work on you, but that will help us merge this in
with some confidence.
cc @shivaram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
