Github user voukka commented on a diff in the pull request:
https://github.com/apache/spark/pull/5244#discussion_r27766535
--- Diff: ec2/spark_ec2.py ---
@@ -700,7 +704,8 @@ def get_instances(group_names):
# Deploy configuration files and run setup scripts on a newly launched
# or started EC2 cluster.
def setup_cluster(conn, master_nodes, slave_nodes, opts, deploy_ssh_key):
- master = master_nodes[0].public_dns_name
+ master = master_nodes[0].public_dns_name if not opts.private_ips else \
--- End diff --
Hello @mdagost! There's a conditional logic being repeated more than 10
times. Probably you might want to extract it in a function. @nchammas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
