sarutak commented on a change in pull request #29757:
URL: https://github.com/apache/spark/pull/29757#discussion_r488777202
##########
File path: core/src/main/resources/org/apache/spark/ui/static/timeline-view.js
##########
@@ -50,9 +50,18 @@ function drawApplicationTimeline(groupArray, eventObjArray,
startTime, offset) {
return "#job-" + jobId;
};
+ var getPathForJobEntry = function(baseElem) {
+ var jobIdText =
$($(baseElem).find(".application-timeline-content")[0]).text();
+ var jobId = jobIdText.match("\\(Job (\\d+)\\)$")[1];
Review comment:
`jobIdText` and `jobId` are calculated
[here](https://github.com/apache/spark/pull/29757/files#diff-0e05a2e8f77e645ac29df29ee145a8b1R48-R49)
so can we reuse them to avoid additional overhead of jQuery selector and regex?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
