zhli1142015 commented on a change in pull request #29757:
URL: https://github.com/apache/spark/pull/29757#discussion_r489085097
##########
File path: core/src/main/resources/org/apache/spark/ui/static/timeline-view.js
##########
@@ -50,9 +50,18 @@ function drawApplicationTimeline(groupArray, eventObjArray,
startTime, offset) {
return "#job-" + jobId;
};
+ var getPathForJobEntry = function(baseElem) {
+ var jobIdText =
$($(baseElem).find(".application-timeline-content")[0]).text();
+ var jobId = jobIdText.match("\\(Job (\\d+)\\)$")[1];
+ return "job/?id=" + jobId;
+ };
+
$(this).click(function() {
var jobPagePath =
$(getSelectorForJobEntry(this)).find("a.name-link").attr("href");
- window.location.href = jobPagePath
+ if (jobPagePath == undefined) {
Review comment:
Thanks @sarutak . we should remove it and use new logic, updated.
> @zhli1142015 Thanks for the fix. The same issue can be in `JobPage`. Could
you confirm it?
Good catch, this also happens for job page. i fixed it in this PR also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
