zhli1142015 commented on a change in pull request #29757:
URL: https://github.com/apache/spark/pull/29757#discussion_r489086672
##########
File path: core/src/main/resources/org/apache/spark/ui/static/timeline-view.js
##########
@@ -50,9 +50,18 @@ function drawApplicationTimeline(groupArray, eventObjArray,
startTime, offset) {
return "#job-" + jobId;
};
+ var getPathForJobEntry = function(baseElem) {
+ var jobIdText =
$($(baseElem).find(".application-timeline-content")[0]).text();
+ var jobId = jobIdText.match("\\(Job (\\d+)\\)$")[1];
Review comment:
Thanks for your comments. i extracted common function `getIdForJobEntry`
for selector and regex, and moved it out of `each` loop. It is only triggered
by click and hover events. i think this is ok here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
