KevinSmile commented on pull request #29770: URL: https://github.com/apache/spark/pull/29770#issuecomment-693345580
Also, I can see that `SparkSubmit.scala` is full of `if...else...`. based on: https://github.com/apache/spark/blob/2e3aa2f0232a539346da3df8a20cd8e7c2b7dd4f/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L290-L301 So can we get the 4-tuple return value of `prepareSubmitEnvironment` correctly if a new user-defined option is added? https://github.com/apache/spark/blob/2e3aa2f0232a539346da3df8a20cd8e7c2b7dd4f/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L220-L228 e.g. the `childArgs` is added base on different modes: https://github.com/apache/spark/blob/2e3aa2f0232a539346da3df8a20cd8e7c2b7dd4f/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L716-L734 I doubt that it would be hard for a user-defined mode to get correct 4-tuple return value of `prepareSubmitEnvironment`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
