KevinSmile edited a comment on pull request #29770: URL: https://github.com/apache/spark/pull/29770#issuecomment-693369153
Just a glance, I'm not very sure about this... Let's say we have a new user-defined cluster manager called `my-Yarn`, which is all the same as `Yarn`, so we just copy the yarn-scheduler code to implement the new one . But what should we do with the following `if(isYarnCluster)` snippet in `SparkSubmit.scala`, copy-paste and change it to `if(isMyYarnCluster)` to get correct `childArgs`? https://github.com/apache/spark/blob/2e3aa2f0232a539346da3df8a20cd8e7c2b7dd4f/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L716-L734 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
