Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5236#discussion_r27792288
  
    --- Diff: 
core/src/test/scala/org/apache/spark/network/nio/ConnectionManagerSuite.scala 
---
    @@ -261,7 +261,7 @@ class ConnectionManagerSuite extends FunSuite {
         val clientConf = new SparkConf
         clientConf.set("spark.authenticate", "false")
         val ackTimeout = 30
    --- End diff --
    
    You could consider renaming this `acktimeoutS` too, but not that important 
either way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to