Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5279#discussion_r27836835
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala 
---
    @@ -94,11 +178,95 @@ trait ScalaReflection {
         case (other, _) => other
       }
     
    +  /**
    +   * Creates a converter function that will convert Catalyst types to 
Scala type.
    +   */
    +  private[sql] def createScalaConverter(dataType: DataType): Any => Any = 
dataType match {
    +    // Check UDT first since UDTs can override other types
    +    case udt: UserDefinedType[_] =>
    +      (item: Any) => udt.deserialize(item)
    +
    +    case arrayType: ArrayType =>
    +      val elementConverter = createScalaConverter(arrayType.elementType)
    +      (item: Any) => item match {
    +        case s: Seq[_] => s.map(elementConverter)
    +        case other => other
    --- End diff --
    
    Is this needed? It may lead to other problems (the items inside other is 
not converted).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to