Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5279#issuecomment-90313848
This looks great. Thanks for working on it! Two high level pieces of
feedback:
- Can you move all this conversion logic to a separate object? Its my
fault this is all in one place, and I'd like to fix that.
- Did you try removing the `other => other` cases? I'd rather actually
have errors now if we are making mistakes on types.
Otherwise this LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
