srowen commented on a change in pull request #29843:
URL: https://github.com/apache/spark/pull/29843#discussion_r494393884
##########
File path: external/kafka-0-10-sql/pom.xml
##########
@@ -79,6 +79,10 @@
<artifactId>kafka-clients</artifactId>
<version>${kafka.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.code.findbugs</groupId>
Review comment:
We may need a new entry in licenses/ and LICENSE for this, if it's not
there already. Likewise for JAXB.
You'll want to run the script in dev/ to update the deps/ files too.
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -118,11 +118,15 @@ private[hive] object IsolatedClientLoader extends Logging
{
hadoopVersion: String,
ivyPath: Option[String],
remoteRepos: String): Seq[URL] = {
+ val hadoopJarName = if (hadoopVersion.startsWith("3")) {
Review comment:
Is this valid for all Hadoop 3.x verisons?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
