Victsm commented on a change in pull request #29855:
URL: https://github.com/apache/spark/pull/29855#discussion_r495112330
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
##########
@@ -238,12 +259,26 @@ public String getID() {
}
} catch (Exception e) {
logger.error("Error while invoking RpcHandler#receive() on RPC id " +
req.requestId, e);
- respond(new RpcFailure(req.requestId,
Throwables.getStackTraceAsString(e)));
+ try {
+ // It's OK to respond the original metadata buffer here, because this
is still inside
+ // the invocation of this method.
+ respond(new RpcFailure(req.requestId,
+ JavaUtils.encodeHeaderIntoErrorString(req.meta.nioByteBuffer(),
e)));
+ } catch (IOException ioe) {
+ // No exception will be thrown here. req.meta.nioByteBuffer will not
throw IOException
+ // because it's a NettyManagedBuffer. This try-catch block is to make
compiler happy.
+ logger.error("Error in handling failure while invoking
RpcHandler#receive() on RPC id {}",
Review comment:
Just to clarify, you are suggesting to use `assert false` to make sure
the code never gets here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
