Victsm commented on a change in pull request #29855:
URL: https://github.com/apache/spark/pull/29855#discussion_r495129332
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java
##########
@@ -43,6 +48,9 @@
* (via BlockTransferService), which has the downside of losing the data if we
lose the executors.
*/
public class ExternalBlockStoreClient extends BlockStoreClient {
+ private static final Logger logger =
LoggerFactory.getLogger(ExternalBlockStoreClient.class);
Review comment:
This is perhaps a miss while we forward port the patch from our internal
Spark 2.3 branch to master.
In Spark 2.3, the logger was only created for then class
`ExternalShuffleClient`.
This has already changed as you mentioned.
Will remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
