Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5376#issuecomment-90650055
Just wanted to leave a comment that, while I think this change is good (and
good practice in general), comparing the generated bytecode is a little
misleading. In hot paths, hotspot would probably optimize the difference away,
since the extra operations have no side-effects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
